WADO Content-Length

leonardorame · May 7th 2017

Hi Marcel, I found the WADO requests from v1.4.19 aren't returning the Content-Length header. Could you add it?, this would allow implementing download progress from client side.

Regards,
Leonardo.

marcelvanherk · May 8th 2017

Hi,

I can do that. Can you specify exactly what needs to be in there?

Marcel

leonardorame · May 8th 2017

Hi Marcel, thanks for answering.

That field specifies the file size in bytes about to be downloaded.

Please find this block in the code (line 21836), the new header field must return the value of the "len" field, I think (not tested) this should do that:

Code

unsigned int len = DFileSize(tempfile);
if (len)
{
  unsigned int extra=0;
  if (memcmp(SilentText, "convert_to_dicom:", 17)==0) extra=64;
  if (memcmp(SilentText, "export:", 7)==0) 	    extra=62;
  if (memcmp(SilentText, "text/plain", 10)==0) // 20120829 force even
  { if (len & 1) len--;
  }
  VR *vr2 = new VR(0x9999, 0x0401, len+extra, TRUE);
  FILE *f;
  f = fopen(tempfile, "rb");
  if (extra==64) sprintf((char *)(vr2->Data), 
    "Content-type: application/dicom\nContent-length: %d\nAccess-Control-Allow-Origin: *\n\n", len); 
  // 64 extra bytes
  if (extra==62) sprintf((char *)(vr2->Data), 
  "Content-type: application/zip\nAccess-Control-Allow-Origin: *\n\n");
  // 62 extra bytes
  fread((char*)(vr2->Data)+extra, 1, len, f);
  fclose(f); 
  SOPVerification.WriteResponse(&PDU, &DCO, vr2);
}

Display More

marcelvanherk · May 8th 2017

Thanks!

The header length needs to be adjusted to account for the extra parameter, I will try to add this soon.

Marcel

leonardorame · Jun 15th 2017

Hi Marcel, did you apply this?.

marcelvanherk · Oct 10th 2017

Hi,

is coming in the 1.4.19b release.

Marcel

marcelvanherk · Oct 13th 2017

Fix released in 1.4.19b

Marcel

WADO Content-Length

Participate now!

Share