Lua forward kills system with NULL database

markpearson · Sep 20th 2011

Hello everyone,

I use lua on a system running linux to modify images before they are sent to another server. This works OK when there is local database but causes a segmentation fault when the database uses the NULL driver. The relevent section from dicom.ini is

Code

[lua]ImportConverter0      =  script('forward to TRAEKIPG;');

The log looks like this:

Code

DGATE (1.4.16e, build Tue Sep 20 14:14:07 2011, bits 64) is running as threaded serverDatabase type: NULL driver (black hole)UPACS THREAD 0: STARTED AT: Tue Sep 20 14:49:40 2011A-ASSOCIATE-RQ Packet Dump        Calling Application Title : "CLOSEDPACS      "        Called Application Title : "BACKUPFWD       "        Application Context : "1.2.840.10008.3.1.1.1", PDU length: 16384        Number of Proposed Presentation Contexts: 2        Presentation Context 0 "1.2.840.10008.5.1.4.1.1.20" 1        Presentation Context 1 "1.2.840.10008.5.1.4.1.1.7" 1Server Command   := 0001Message ID       := 5dddMove Originator Message ID := 0006Move Originator AE         := CLOSEDPACS      ImportConverter-1.0: forwarded object to TRAEKIPGSegmentation fault

Using strace adds a little more information:

Code

ImportConverter-1.0: forwarded object to TRAEKIPG
 <unfinished ...>
+++ killed by SIGSEGV +++
Segmentation fault

If I use the standard importconverter described in DICOM Routing without database everything works OK. I suspect lua does not know where to read the file from when there is no database.

Mark

marcelvanherk · Sep 22nd 2011

I will add it to the buglist.

Marcel

marcelvanherk · Sep 29th 2011

Hi,

I have not easily reproduced this. Could you use gdb to get a make a backtrace of the error location?

gdb dgate
run -v
<wait for crash>
bt

Marcel

markpearson · Sep 30th 2011

Hi,

Gdb appears to show empty storage. Let me know if you want more information.

Code

Starting program: /usr/local/conquest/reporting/dgate -v
[Thread debugging using libthread_db enabled]
DGATE (1.4.16e, build Fri Sep 30 10:36:53 2011, bits 64) is running as threaded server
Database type: NULL driver (black hole)
[New Thread 0x7ffff6c19700 (LWP 10106)]


UPACS THREAD 0: STARTED AT: Fri Sep 30 10:37:27 2011
A-ASSOCIATE-RQ Packet Dump
        Calling Application Title : "CLOSEDPACS      "
        Called Application Title : "BACKUPFWD       "
        Application Context : "1.2.840.10008.3.1.1.1", PDU length: 16384
        Number of Proposed Presentation Contexts: 2
        Presentation Context 0 "1.2.840.10008.5.1.4.1.1.20" 1
        Presentation Context 1 "1.2.840.10008.5.1.4.1.1.7" 1
Server Command   := 0001
Message ID       := 624f
Move Originator Message ID := 0006
Move Originator AE         := CLOSEDPACS      
ImportConverter-1.0: forwarded object to TRAEKIPG


Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff6c19700 (LWP 10106)]
0x00000000004a9a8a in CallImportConverterN (DDO=0xc33a40, N=-1, pszModality=0x7ffff6bf3e40 "NM", pszStationName=0x7ffff6bf3df0 "Atlantis", 
    pszSop=0x7ffff6bf3da0 "1.3.46.670589.28.1.2.0.21.96.163.65.94.20101018092935.92.4", patid=0x7ffff6bf3cb0 "1077877", PDU=0x7ffff6c16440, Storage=0x7ffff6bf3e90 "", 
    Script=0x7ffff6beb830 "forward to TRAEKIPG;") at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:6661
6661            PDU[part].SetApplicationContext ( AppUID );
(gdb) bt
#0  0x00000000004a9a8a in CallImportConverterN (DDO=0xc33a40, N=-1, pszModality=0x7ffff6bf3e40 "NM", pszStationName=0x7ffff6bf3df0 "Atlantis", 
    pszSop=0x7ffff6bf3da0 "1.3.46.670589.28.1.2.0.21.96.163.65.94.20101018092935.92.4", patid=0x7ffff6bf3cb0 "1077877", PDU=0x7ffff6c16440, Storage=0x7ffff6bf3e90 "", 
    Script=0x7ffff6beb830 "forward to TRAEKIPG;") at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:6661
#1  0x00000000004a2317 in luascript (L=0xc31750) at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:5340
#2  0x00000000004fca86 in luaD_precall (L=0xc31750, func=0xc31b30, nresults=0) at /home/markp/conquest/source/conquestlinux1416e/source/lua_5.1.4/ldo.c:319
#3  0x000000000050c32e in luaV_execute (L=0xc31750, nexeccalls=1) at /home/markp/conquest/source/conquestlinux1416e/source/lua_5.1.4/lvm.c:587
#4  0x00000000004fcd31 in luaD_call (L=0xc31750, func=0xc31b20, nResults=1) at /home/markp/conquest/source/conquestlinux1416e/source/lua_5.1.4/ldo.c:377
#5  0x00000000004f6f4c in f_call (L=0xc31750, ud=0x7ffff6bec650) at /home/markp/conquest/source/conquestlinux1416e/source/lua_5.1.4/lapi.c:800
#6  0x00000000004fbca7 in luaD_rawrunprotected (L=0xc31750, f=0x4f6f17 <f_call>, ud=0x7ffff6bec650) at /home/markp/conquest/source/conquestlinux1416e/source/lua_5.1.4/ldo.c:116
#7  0x00000000004fd135 in luaD_pcall (L=0xc31750, func=0x4f6f17 <f_call>, u=0x7ffff6bec650, old_top=16, ef=0) at /home/markp/conquest/source/conquestlinux1416e/source/lua_5.1.4/ldo.c:463
#8  0x00000000004f6ff5 in lua_pcall (L=0xc31750, nargs=0, nresults=1, errfunc=0) at /home/markp/conquest/source/conquestlinux1416e/source/lua_5.1.4/lapi.c:821
#9  0x00000000004a68c7 in do_lua (L=0x7ffff6c16bb8, cmd=0x7ffff6bf1e90 "script('forward to TRAEKIPG;');", sd=0x7ffff6bec830)
    at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:6050
#10 0x00000000004a703e in CallImportConverterN (DDO=0xc33a40, N=0, pszModality=0x7ffff6bf3e40 "NM", pszStationName=0x7ffff6bf3df0 "Atlantis", 
    pszSop=0x7ffff6bf3da0 "1.3.46.670589.28.1.2.0.21.96.163.65.94.20101018092935.92.4", patid=0x7ffff6bf3cb0 "1077877", PDU=0x7ffff6c16440, Storage=0x7ffff6bf3e90 "", Script=0x0)
    at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:6124
#11 0x00000000004af6dc in CallImportConverters (DDO=0xc33a40, pszModality=0x7ffff6bf3e40 "NM", pszStationName=0x7ffff6bf3df0 "Atlantis", 
    pszSop=0x7ffff6bf3da0 "1.3.46.670589.28.1.2.0.21.96.163.65.94.20101018092935.92.4", patid=0x7ffff6bf3cb0 "1077877", PDU=0x7ffff6c16440, Storage=0x7ffff6bf3e90 "")
    at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:7857
#12 0x00000000004b450d in SaveToDisk (DB=..., DDOPtr=0xc33a40, Filename=0x7ffff6bf4750 "\236G\277\366\377\177", NoKill=0, PDU=0x7ffff6c16440, Syntax=0, nopreget=0)
    at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:9271
#13 0x00000000004ec1f5 in MyUnknownStorage::CheckObject (this=0x7ffff6bf8600, DDO=0xc33a40, PDU=0x7ffff6c16440) at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:11091
#14 0x0000000000458956 in UnknownStorage::Read (this=0x7ffff6bf8600, PDU=0x7ffff6c16440, DCO=0x7ffff6bf8350, DDO=0xc33a40)
    at /home/markp/conquest/source/conquestlinux1416e/source/storage.cxx:153
#15 0x00000000004cf010 in StorageApp::ServerChild (this=0x958be0, theArg=6) at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:16445
#16 0x00000000004c9cdb in DriverApp::ServerChildThread (this=0x958be0, Socketfd=6) at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:14919
#17 0x00000000004c9d1c in DriverHelper (theApp=0x958be0) at /home/markp/conquest/source/conquestlinux1416e/source/dgate.cpp:14944
#18 0x00007ffff7bc6971 in start_thread () from /lib/libpthread.so.0
#19 0x00007ffff6d0092d in clone () from /lib/libc.so.6
#20 0x0000000000000000 in ?? ()

Display More

marcelvanherk · Sep 30th 2011

Ok,

this helps to look further. It may take a while though, I will be travelling next week.

Marcel

marcelvanherk · Sep 30th 2011

Hi,

I found it, a silly typo:

In dgate.cpp, line 6578, replace:

if (N<0 && N>=20) N = 0;

By

if (N<0 N>=20) N = 0;

And recompile. Can you give it a try?

Marcel

marcelvanherk · Oct 2nd 2011

Hi,

I released this fix in 1.4.16f yesterday. Note that all lua forwards for now use one connection (0.0), i.e., it will delay if do multiple forwards and expect multiple one to remain open for the same series. In other words, stick to one lua forward for now.

Marcel

markpearson · Oct 3rd 2011

Hi,

Thanks, that fixed the error.

I'll implement it on one system that only does one forward, but wait for a better implementation on another system that sends to 5 destinations.

marcelvanherk · Oct 10th 2011

Hi,

In the upcoming release, you can add a "channel N" clause to forwards to select one of up to 20 simultaneous forwards from lua. In the scripts this value was set from the statement position in the converter string.

Marcel

Lua forward kills system with NULL database

Participate now!

Share