Posts by mmoring

Hi all,

We're looking into connecting our Conquest PACS with an XDS system (Cross-Enterprise Document Sharing).

It should work if the PACS supports default DICOM actions like store, query, retrieve etc. which should be no problem for Conquest, but I'd like to know if anyone has had any experience with Conquest and an XDS.

Thanks,

Michael

Hi,

I've encountered a small problem with conquest while using MariaDB >= 10.2.4 (needed for Galera clustering)
Since that version 'Rows' has become a protected keyword leading to some mysql errors:

***Failed MYSQLExec : INSERT INTO DICOMImages (SOPInstanc, SOPClassUI, ImageNumbe, ImageDate, ImageTime, SamplesPer, PhotoMetri, Rows, Colums, BitsStored, ImageType, ImagePat, SeriesInst, AccessTime, ObjectFile, DeviceName) VALUES (**redacted**)***Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'Rows, Colums, BitsStored, ImageType, ImagePat, SeriesInst, AccessTime, ObjectFil' at line 1***Unable to DB.Add()

The DICOMImages table contains a column named 'Rows' which now throws an error with MariaDB versions >=10.2.4
I've modified dbsql.cpp to escape column names when inserting data into the database and we can now use conquest again with newer versions of MariaDB.
I haven't looked into the code further but this protected keyword will probably cause problems elsewhere, though with headless linux use we have yet to find other issues beside this one.

Below is a patch to fix the above issue:

diff --git a/src/dbsql.cpp b/src/dbsql.cpp
index 34d4fb5..af5ca2d 100644
--- a/src/dbsql.cpp
+++ b/src/dbsql.cpp
@@ -1257,7 +1257,9 @@ AddToTable(
 			{
 			if(CIndex)
 				strcat(Columns, ", ");
+			strcat(Columns, "`");
 			strcat(Columns, DCMGateDB [ Index ] . SQLColumn);
+			strcat(Columns, "`");
 			++CIndex;
 			}
 		++Index;
@@ -1389,14 +1391,18 @@ UpdateOrAddToTable(
 			{
 			if(CIndex)
 				strcat(Columns, ", ");
+			strcat(Columns, "`");
 			strcat(Columns, DCMGateDB [ Index ] . SQLColumn);
+			strcat(Columns, "`");
 			++CIndex;
 			}
 		if (AllowEmptyPatientID && (vr==NULL || vr->Length==0) && DCMGateDB[Index].Group==0x0010 && DCMGateDB[Index].Element==0x0020 && Patid[0])
 			{
 			if(CIndex)
 				strcat(Columns, ", ");
+			strcat(Columns, "`");
 			strcat(Columns, DCMGateDB [ Index ] . SQLColumn);
+			strcat(Columns, "`");
 			++CIndex;
 			}