Posts by jweste

Hi, Marcel

I build OHIF to use the extensions in runtime as 'umd' bundle.

But RTStruct is not working as you already know.

I added all extensions.

The only way I had success to all works is building as PWA, using "yarn build".

But, it generate many chunks in dist folder. IMHO, I don't see it as a problem
But all extensions work wonderfull.

Just deploy the dist folder

Luiz

it was not necessary until now

Hi, Marcel

Could you test this one?

dicomRoutes_fix.zip

Quote from marcelvanherk

Luiz,

can you implement the limit and offset again in your app? I am stuck reading 80.000 studies!

Marcel

Hi Marcel,

OK, one moment please.

Quote from marcelvanherk

Hi,

great to hear. the API supports it, but the app I distribute with conquest does not have this feature. I am looking for a single json packaged version of the current OHIF (like in the app/ohif folder), but I cannot find it or directions how to make it. The offcial build instructions create quite a large folder.

Marcel

Hi, Marcel

I sent you a message in your wall about it.

Regards, Luiz

I have seen you created a new function "wadoparse" to make easier wado call.

And you did a great work in your php qido/wado webapi.

Hi, Marcel

This function works almost all times, but fail to conquest image "HEAD EXP2"

[CONQUESTSRV1] Sending file : F:\Programas\AppProg\dicom150bteste\Data\0009703828\1.3.46.670589.5.2.10.2156913941.892665339.860724_0001_003000_14579035620001.dcm
[CONQUESTSRV1] Image Loaded from Read Ahead Thread, returning TRUE
[CONQUESTSRV1] JPEG decompress started.
[CONQUESTSRV1] Debug[DecompressJPEGL]: H = 320, W = 320, Bits = 12 in 16, Components = 1, Frames = 1
[CONQUESTSRV1] ***[JPEG Library]: Unsupported marker type 0xf7
[CONQUESTSRV1] ***[DecompressImage]: JPEG library decompression error
[CONQUESTSRV1] C-Get (StudyRoot)
[CONQUESTSRV1] UPACS THREAD 503: ENDED AT: Tue Aug 23 09:09:32 2022
[CONQUESTSRV1] UPACS THREAD 503: TOTAL RUNNING TIME: 0 SECONDS

function getframe(ae, bd, st, se, sop, fr)
  local remotecode = 
[[
  local ae=']]..(ae or servercommand('get_param:MyACRNema'))..[[';
  local q2=DicomObject:new();
  q2.QueryRetrieveLevel='IMAGE'
  q2.StudyInstanceUID=']]..st..[['
  q2.SeriesInstanceUID=']]..(se or '')..[['
  q2.SOPInstanceUID=']]..(sop or '')..[['
  local fr=]]..(fr or 1)..[[
  local r = dicomget(ae, 'IMAGE', q2)
  local s=tempfile('.txt') 
  f = io.open(s, 'wb')
  f:write(r[0]:GetImage(tonumber(fr)-1));
  f:close()
  returnfile=s
]]

...

Hi,

I just saw conquest is ordering.

But, The result is not sorted in OHIF. I suspect it is making other ordering in the front end.

Some questions:

1. Does it work to sort metadata?

2. Is there other param to sort asc or desc?

function remotemetadata(ae, level, st, se, sop)

  local remotecode = 
[[
  local ae=']]..ae..[[';
  local level=']]..level..[[';
  local q2=DicomObject:new();
  q2.QueryRetrieveLevel='IMAGE'
  q2.StudyInstanceUID=']]..st..[['
  q2.SeriesInstanceUID=']]..(se or '')..[['
  q2.SOPInstanceUID=']]..(sop or '')..[['
  q2['9999,0202']='-Private,7FE0,30060039'
  q2['9999,0C00'] = 'INSTANCE NUMBER'  -- sort instance number????
  local r = dicomget(ae, 'IMAGE', q2)
  r = r:Serialize(true,false,true)
  local s=tempfile('.txt') local f=io.open(s, "wb") f:write(r) returnfile=s f:close()
]]
 local f = servercommand('lua:'..remotecode)
 return f
end

Quote from marcelvanherk

Hi Luiz,

I have added private control tags for limit and offset:

foreach ($params as $key => $value) {

if ($key=='limit') $params["99990C01"]=$value;

if ($key=='offset') $params["99990C02"]=$value;

};

you can add these it will avoid the overflow. Also add 99990C00 for the sort!

Display More

Marcel,

Awesome,

Thank you

I have modified latest ohif to be called on start time with:

http://localhost:3000/?Patient…19800101&PatientName=john

Otherwise, the default is get all studies and It will overload Conquest.

And, I intent make changes in the API to avoid overload conquest if:

1. PatientID is not passed to API, or

2. PatientName length is lower than NN chars or

3. and the range StudyDateTo-StudyDateFrom is lower than DD days.

What do you think?

Quote from marcelvanherk

Hi,

and with my frame function you should be able to use wadors for image rendering too.

Marcel

Hi, Marcel

I just tested and works well.

In your opinion which is faster? wadouri or getframe?

Hi, Marcel,

Here is my latest lua script and node api.

Now working with OHIF RTStruct with your help.

Tested with latest OHIF code.

I found a bug in date input range in the OHIF UI and I submited it on Git.

But this doesn´t impact the API

Another time, I will do a "cleanup" in the code removing unnecessary comments.

Here is my OHIF setup. I changed since the last time I posted here.

 dicomWeb: [
      {
        name: 'CONQUESTSRV1',
        wadoUriRoot: 'http://localhost:3002/api/dicom/wadouri',
        qidoRoot: 'http://localhost:3002/api/dicom/rs',
        wadoRoot: 'http://localhost:3002/api/dicom/rs',
        qidoSupportsIncludeField: true,
        imageRendering: 'wadouri',
        thumbnailRendering: 'wadors',
        enableStudyLazyLoad: false,
        supportsFuzzyMatching: false,
      },
    ],

dicomRoutes.zip

queryfunctions.zip

Hi, Marcel,

Working!!! My God!!!!

I sent you a PM about problem multiple images.

If you can, please fix my code.

OK, But I´d like a valid image to test.

Do you has someone such as you show above?

All images I downloaded has problem.

Is possible I get a copy of this dicom rt image?

Hi, Marcel,

Do you already have success rendering RTStruct into dicom image?

Quote from marcelvanherk

A few more fixes just posted!

Would It not be to start with "i=0"?

And don´t I need close the boundary after each image?

Such as:

...

for i=0, #r-1 do
        r[i]:Write(t)
        f:write("--"..obd.."\r\n")
        f:write("Content-Type: application/dicom\r\n")
        f:write("Content-Transfer-Encoding: binary\r\n\r\n")
        g = io.open(t, "rb")
        f:write(g:read('*a'))
        f:write("--"..obd.."--\r\n\r\n")
        g:close()
      end
      f:close()
      os.remove(t)
      returnfile=s
]]
local f = servercommand('lua:'..remotecode, 'binary')
io.write(f)
end

Hi, Marcel

I get an error:

*** lua run error ...xt-iclindoctor\dicomapi/api/dgate/queryfunctions.lua:77: bad argument #1 to 'write' (string expected, got nil) in 'dofile([[F:\Programas\vuejs\nuxt-iclindoctor\dicomapi/api/dgate/queryfunctions.lua]]);getinstance([[CONQUESTSRV1]],[[simpleconquestqidobridgeb1f197b57dd69deb7e626764cf53f68c]],[[1.2.840.113619.2.55.3.41169751.266.1362974723.224]], [[1.2.246.352.71.2.166727324.89143.20130312163425]], [[1.2.246.352.71.4.166727324.13361.20130314104214]])'

function getinstance(ae, bd, st, se, sop)
  local remotecode = 
    [[
      local ae=']]..(ae or servercommand('get_param:MyACRNema'))..[[';
      local obd=']]..bd..[['
      local q2=DicomObject:new();
      q2.QueryRetrieveLevel='IMAGE'
      q2.StudyInstanceUID=']]..st..[['
      q2.SeriesInstanceUID=']]..(se or '')..[['
      q2.SOPInstanceUID=']]..(sop or '')..[['
      local r = dicomget(ae, 'IMAGE', q2)
      local s=tempfile('.txt')
      local t=tempfile('.txt')
      f = io.open(s, "wb")
      for i, #r-1 do
        r[i]:Write(t) end
        f:write("--"..obd.."\r\n")
        f:write("Content-Type: application/dicom\r\n")
        f:write("Content-Transfer-Encoding: binary\r\n\r\n")
        g = io.open(t, "rb")
        f:write(g:read('*a'))
        g:close()
      end
      f:write("--"..obd.."--\r\n\r\n")
      f:close()
      os.remove(t)
      returnfile=s
   ]]
    
   local f = servercommand('lua:'..remotecode, 'binary')
   io.write(f)
end

Hi, Marcel

I am passing the boundary right into lua function to avoid do it in node API.

To multiple instances, I have doubt about how loop the results to add the boundary/multipart

Is it ok?

// node.js
const boundary =
      "simpleconquestqidobridge" + crypto.randomBytes(16).toString("hex");
    const cmd = `--dolua:dofile([[${APIFOLDER}/queryfunctions.lua]]);getinstance([[${CQAE}]],[[${boundary}]],[[${study}]], [[${series}]], [[${instance}]],[[${frame}]])`;
....
...

// lua script
function getinstance(ae,bd, st, se, sop)
  local remotecode = 
[[
  local ae=']]..(ae or servercommand('get_param:MyACRNema'))..[[';
  local q2=DicomObject:new();
  q2.QueryRetrieveLevel='IMAGE'
  q2.StudyInstanceUID=']]..st..[['
  q2.SeriesInstanceUID=']]..(se or '')..[['
  q2.SOPInstanceUID=']]..(sop or '')..[['
  local r = dicomget(ae, 'IMAGE', q2)
  local s=tempfile('.txt') 
  r[0]:Write(s)
  returnfile=s
]]
 local f = servercommand('lua:'..remotecode, 'binary')
 io.write("--"..bd.."\r\n")
 io.write("Content-Type: application/dicom\r\n");
 io.write("Content-Transfer-Encoding: binary\r\n\r\n")
 io.write(f)
 io.write("--"..bd.."--\r\n\r\n")
end

Quote from marcelvanherk

I got the RTSTRUCT working too in php! I'll have a look at the coding error.

Code

function getinstance($st,$se,$sop) {
include 'config.php';
ob_start();
passthru($exe.' "--dolua:dofile([[rquery.lua]]);getinstance([[CONQUESTSRV1]],[['.$st.']],[['.$se.']],[['.$sop.']])"');
$var = ob_get_contents();
ob_end_clean();
header('Access-Control-Allow-Headers: *');
header('Access-Control-Allow-Origin: *');
header('Content-Type: multipart/related; boundary=simpleconquestqidobridge3141592654');

echo("--simpleconquestqidobridge3141592654\r\n");
echo("Content-Type: application/dicom\r\n");
echo("Content-Transfer-Encoding: binary\r\n\r\n");
echo $var;
echo("--simpleconquestqidobridge3141592654--\r\n\r\n");
}

Display More

What the lua script of getinstance?